All configuring Remove approvals by Code Owners if their files changed at group level
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Proposal
We want to improve our way of working with MRs, specifically regarding approvals. To maintain a high-security standard, we enabled the “Remove all approvals” setting when a new commit occurs. It works reasonably well when one approval is required. However, it requires significant effort to obtain all approvals again when multiple approvers are involved based on ownership in CODEOWNERS. GitLab has a great option for this use case - Remove approvals by Code Owners if their files changed.
But there are two problems with it:
- This option doesn’t exist at the Group level, only at the project level. Because of this, it’s difficult to enforce.
- If this option is enabled at the project level and the CODEOWNERS file doesn’t exist, GitLab will not remove any approvals, making it harder to implement centrally (we should differentiate projects with and without CODEOWNERS and apply relevant settings).
Desired behavior is:
- We enable the “Remove approvals by Code Owners if their files changed” feature on the instance or group level.
- If the project doesn’t have a code owner file, it should fall back to “Remove all approvals.”
Maybe we missed something, and it’s possible to implement such behavior?
Edited by 🤖 GitLab Bot 🤖