Remove logic to auto create any_approver rules in approval rule API

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

https://gitlab.com/gitlab-org/gitlab/-/blob/44d105ba726956f66b1f1352a466d7ab7e6e124f/ee/app/services/approval_rules/create_service.rb#L50

Our create service converts the rule to an any_approver rule if no user or groups are passed.

This behavior feels confusing. I'm proposing we modify this logic so users have to explicitly pass the rule type if they want an any_approver rule.

This will remove the logic that checks if any users or groups were passed and then converts it into an any_approver rule reducing complexity and technical debt.

This should also modify the documentation.