[go: up one dir, main page]

Update the "submit a review" workflow to reflect current reviewer's state

Proposal

Update the workflow to "submit a review" by updating the button and interactions.

Changes

  1. Button label "Your review" changes to conveys what happens when the button is activated:
    1. When there are no pending comments Review changes
    2. When pending comments exists, changes to Finish review
  2. Visual changes to reflect reviewer's review state:
    1. If you are assigned as reviewer:
      1. No review left -> Blue
      2. Requested changes -> Red outline
      3. Approved -> Blue outline
    2. If you are not assigned as a reviewer:
      1. Default color (white)
  3. Dropdown button for review state
    1. Commented Button does not change to a dropdown
      1. Same button behaviour as always (Opens sidebar)
    2. Requested changes
      1. Dropdown: 1 option
        1. Update review opens the review sidebar
    3. Approved
      1. Dropdown: 2 options
        1. Update review opens the review sidebar
        2. Reset approval unapproves
  4. Add link to feedback issue in the review sidebar

Engineering notes

  1. We need to fetch the current users reviewer state, we could do this on page load so we don't need a loading state
  2. However we get this data we need to update in realtime

Design

Figma

Edited by 🤖 GitLab Bot 🤖