Follow-up from "UI elements to control tags sort order added"
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The following discussion from !210781 should be addressed:
-
@smaglangit started a discussion:
suggestion (non-blocking, followup): I think it would be nice to remove
sortOptionsfrom the backend as well since we don't use it anymore?
Implementation Guide
- Apply the following patch
Index: app/helpers/sorting_helper.rb
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/helpers/sorting_helper.rb b/app/helpers/sorting_helper.rb
--- a/app/helpers/sorting_helper.rb (revision ec1d154526effad710f6449802350f3f56ce26f7)
+++ b/app/helpers/sorting_helper.rb (date 1764808066687)
@@ -88,16 +88,6 @@
}
end
- def tags_sort_options_hash
- {
- sort_value_name => sort_title_name,
- sort_value_oldest_updated => sort_title_oldest_updated,
- sort_value_recently_updated => sort_title_recently_updated,
- sort_value_version_desc => sort_title_version_desc,
- sort_value_version_asc => sort_title_version_asc
- }
- end
-
def label_sort_options_hash
options = {}
options[sort_value_relevance] = sort_title_relevance if params[:search].present?
Index: app/views/projects/tags/index.html.haml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/views/projects/tags/index.html.haml b/app/views/projects/tags/index.html.haml
--- a/app/views/projects/tags/index.html.haml (revision ec1d154526effad710f6449802350f3f56ce26f7)
+++ b/app/views/projects/tags/index.html.haml (date 1764808066684)
@@ -30,7 +30,7 @@
= s_('TagsPage|New tag')
.row-content-block
- #js-tags-sort-dropdown{ data: { filter_tags_path: filter_tags_path(search: @search, sort: @sort), sort_options: tags_sort_options_hash.to_json } }
+ #js-tags-sort-dropdown{ data: { filter_tags_path: filter_tags_path(search: @search, sort: @sort) } }
= render_if_exists 'projects/commits/mirror_status'
Index: spec/helpers/sorting_helper_spec.rb
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/spec/helpers/sorting_helper_spec.rb b/spec/helpers/sorting_helper_spec.rb
--- a/spec/helpers/sorting_helper_spec.rb (revision ec1d154526effad710f6449802350f3f56ce26f7)
+++ b/spec/helpers/sorting_helper_spec.rb (date 1764808066690)
@@ -190,18 +190,6 @@
end
end
- describe '#tags_sort_options_hash' do
- it 'returns a hash of available sorting options' do
- expect(tags_sort_options_hash).to include({
- sort_value_name => sort_title_name,
- sort_value_oldest_updated => sort_title_oldest_updated,
- sort_value_recently_updated => sort_title_recently_updated,
- sort_value_version_desc => sort_title_version_desc,
- sort_value_version_asc => sort_title_version_asc
- })
- end
- end
-
describe 'with `forks` controller' do
before do
stub_controller_path 'forks'
Edited by 🤖 GitLab Bot 🤖