[go: up one dir, main page]

Update Protected Branches codeowners text string for consistency

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Context

In Source Code settings, the Protected branches section and Branch rules sections have a setting for Require code owner approval. However, the text string is slightly inconsistent between all 3 areas:

!213475 (comment 2906731625)

Group - Protected branches Project - Protected branches Project - Branch rules

group.png

Creation: Require approval from code owners

Overview table: Code owner approval

project.png

Creation: Require approval from code owners

Overview table: Code owner approval

branch rule.png

Setting text:

Require code owner approval

It's odd that the text is inconsistent between: creating a new Protected branch, Protected branch overview table, Branch rule setting. In an ideal world, I would recommend unifying all 3 pieces of text but I know we were looking to remove Protected branches because it was redundant with Branch rules. So I'm not sure how worth it it is to update all the UI text...

Design recommendation

Update the UI text to Require code owner approval for the Group Protected branches and Project Protected branches sections. Branch rules is already using the correct text.

Group - Protected branches Project - Protected branches Project - Branch rules

group.png

Creation: Require code owner approval

Overview table: Require code owner approval

project.png

Creation: Require code owner approval

Overview table: Require code owner approval

branch rule.png

Setting text:

Require code owner approval

Edited by 🤖 GitLab Bot 🤖