Refactor Git HTTP throttling exclusion logic into helper method
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
Refactor the Git HTTP throttling exclusion logic in lib/gitlab/rack_attack/request.rb to improve code readability by extracting it into a dedicated helper method.
Background
In !213141 (merged), we added logic to exclude Git HTTP requests from the authenticated web throttle. The implementation works correctly but could be more readable when viewed outside the context of the MR.
Proposal
Move the exclusion logic into a helper method named exclude_git_http_from_web_throttling? and use that method in the throttle configuration. This will make the code more self-documenting and easier to understand.
Related
- !213141 (merged) - Original implementation
- #581142 - Parent issue
- !213141 (comment 2905041913) - Original suggestion
Edited by 🤖 GitLab Bot 🤖