Backfill all the missing fields of workspaces_agent_config that are stored in workspaces_agent_config_versions table
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Issue: Ensure workspaces_agent_configs for older versi... (#541902 - closed)
The following discussion from !200608 (merged) should be addressed:
-
@ashvins Thanks. The above is correct and what we agree with @vtak in the sync discussion.
And it's not just about if the defaults change, but also that the approach in this MR is more difficult to maintain and reason about, because we have to keep the defaults in sync with the schema.
With the migration approach, we "just" have to ensure the backfill versioned table migration is done at the time that we modify anything in the main table.
We also discussed noting this in the domain developer docs section that talks about papertrail, but not trying to programatically enforce it, because that would be much effort.
We also discussed that ideally we'd like to scrap papertrail and just use raw tables, now that we have seen that it adds more complexity than its worth. But in the long term we ideally want to get rid of the agent config altogether and move it to first-class settings, so that's not worth the effort now.
But for now, we still need to do a migration to catch up and backfill all the existing data in the papertrail version table records with missing values.
The work you did in this MR to identify which field updates are needed will be useful for that.
Can you please create an issue for that, then update this thread (and top line of the description) with a link to it. Then I think we can close this one out?
TL;DR- We need to backfill all the missing fields of agent_config that are stored in workspaces_agent_config_versions table.