[go: up one dir, main page]

Skip to content

Suggestion functionality requires workaround in merge request reviews

Problem Description

The suggestion functionality in merge request reviews is not working as expected. Users cannot directly use the "Insert suggestion" feature when reviewing code changes. Instead, they must first add a regular comment and then navigate backwards to convert it into a suggestion.

Current Behavior

  1. User opens a merge request and clicks the "Changes" tab
  2. User clicks on a line to add a comment
  3. User clicks the "Insert suggestion" icon in the toolbar
  4. Expected: Suggestion interface should appear immediately
  5. Actual: No suggestion interface appears, requiring the workaround below

Workaround Required

To create a suggestion, users must:

  1. Add a regular comment first
  2. Submit or start the review with the regular comment
  3. Go back to edit the comment
  4. Then convert it to a suggestion format

Impact

  • User Experience: Creates friction in the code review process
  • Efficiency: Adds unnecessary steps to a common workflow
  • Adoption: May discourage use of the helpful suggestions feature

Steps to Reproduce

  1. Navigate to any merge request with code changes
  2. Click the "Changes" tab
  3. Click the comment icon on any line of code
  4. Click the "Insert suggestion" icon in the comment toolbar
  5. Observe that suggestion functionality doesn't activate

Expected Behavior

The "Insert suggestion" icon should immediately populate a code block with the current line content, allowing users to edit and suggest changes directly without requiring a workaround.

Edited by 🤖 GitLab Bot 🤖