[go: up one dir, main page]

Skip to content

Update reviewer list retrieval to new/updated back end solution

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

[Part of Intelligent Reviewer Assignment]

During our early team discussions of the IRA feature, we left it mostly up to the backend to decide the right path forward for providing this new - smarter - data.

There are currently two (I believe) ways reviewers are available to an MR:

  1. A single API endpoint that returns a list of any user who is eligible to review the current MR
  2. A GraphQL data point that returns eligible users along with each approval rule

It is this author's opinion that the new behavior should be on a new API endpoint that combines the two behaviors: a single endpoint that - with no intervention - returns a list of users who are eligible to review this MR, but that takes a parameter like ?approval_rule=[ID, ID, ID] that further restricts the list to only those eligible for the provided approval rules.

Regardless of how the back end implements this feature, the front end will need to update its source to retrieve reviewers to use the new way.
The work here is somewhat unknown as it will depend significantly on the choices the back end makes and on the architecture implemented in Update approval rule reviewer dropdown to only ... (#548623) and especially in Move reviewer modification to single, global lo... (#548622).

Edited by 🤖 GitLab Bot 🤖