Make closed threads without answers look similar to other closed threads

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Work on this issue
• Close this issue

Original issue content

It is visually difficult to distinguish between threads resolved without comment and unresolved threads. This results in reviewers accidentally commenting on resolved threads, reopening them in the process.

Steps to reproduce

1. Create and close a thread without comment
   1. Create a merge request
   2. Use the comment box at the bottom to create a new thread
   3. You see something like this:
   4. Resolve the thread
   5. You end up with something like this:
   6. Notice how little visual difference there is between the two images.
2. Create and close a thread with comment
   1. Create a merge request
   2. Use the comment box at the bottom to create a new thread
   3. Use the comment box under the thread to add a comment to the thread
   4. Close the thread
   5. You end up with something like this

Example Project

See this example Merge Request

What is the current bug behavior?

Resolved threads without comments visually resemble unresolved threads.

What is the expected correct behavior?

Resolved threads without comments visually resemble other resolved threads.

Relevant logs and/or screenshots

See reproduction steps.

Output of checks

This bug happens on GitLab.com

Issue

There are a few different types of comments on the MR overview tab (shown in the Current screenshot, excluding diff comments):

1. Standalone comment
2. Threaded comment (with at least one reply)
3. Threaded comment (with no replies)
4. Threaded comment (with deleted replies)

Threaded comments can be resolved, whether or not they have any replies, but depending on those replies the UI can look unexpectedly different.

Proposal

If a threaded comment has no replies but is resolved, collapse the text-box container into an expandable section, visually similar to the 2 replies... section

When expanded, the textbox would appear as normal.

Current	Proposed

Other considerations

Work items gets around some of these issues by:

• Not allowing users to "Start a thread" when commenting
• Reverting a thread to a standalone comment when all replies are deleted

We can't do the same here because open threads are more functional in MRs; they can block a merge. If we just removed the textbox area altogether for scenarios 3 and 4 it would look like standalone comments can be resolved, which they can't.