[go: up one dir, main page]

Skip to content

Query and render commit details (expandable section)

Description

This is part of a bigger effort to refactor the repository Commit list.

As part of this issue we should implement an expandable section for commit details. Upon expanding, we should query and render the commit details.

🎨 Figma

Screen Notes
Commit drawer

1.2 Proposal - expanded.jpg

1.3 Proposal - expanded hover popovers.jpg

  • Grid layout was designed by the Workspaces team (Figma). There can be some development coordination between teams to reuse layouts.
  • Similar MR badge is being used in the Code > Branches page.
  • Hovering over the MR badge will trigger the MR popover (hover here example !168363 (closed)).
  • Hovering over a username will trigger the user popover.
  • The message field should be truncated at about 450 characters. (i.e. display an ellipsis when messages are very long). &17482 (comment 2567908976)
  • Please add analytics on the Expand/Collapse drawer, so we understand how often users are clicking to expand details of a commit.
Commit drawer overflow

1.4 Proposal - overflow.jpg

Any overflow content inside a commits detail drawer should wrap onto the next line.

For overflowing users in Merged/Approved/Reviewed/Co-authored by:

  • Show 2 lines of content (if you need a number, somewhere in the range of 6 - 10 usernames is fine. Feel free to adjust as you see fit.)
  • If there are additional usernames, show a +# badge showing the number of overflowed elements. On hover, the badge will say # more <approvers/reviewers/co-authors>.
  • &17482 (comment 2567908976)

Mobile

< TBD @alyssatrinh >

Edited by Alyssa Trinh