Return only remote_development enabled agents on cluster agent queries without breaking existing endpoints

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Work on this issue
• Close this issue

MRs:

Add `ALL` filter to cluster agent query (!192329 - merged)

Description

As per Product input, in this comment, we should be able to return organization workspaces cluster agents that have enabled remote development. This is to support the current proposed UI .

The existing namespace/group agent APIs will also be adapted to return enabled agents, however, this will require maintaining the deprecated but unremoved endpoints to still behave as is (return enabled and disabled), i.e:

• https://docs.gitlab.com/api/graphql/reference/#groupremotedevelopmentclusteragents
• https://docs.gitlab.com/api/graphql/reference/#namespaceremotedevelopmentclusteragents

Pending breaking change removal

Acceptance criteria

• Restrict organization cluster agents that have remote development enabled only
• Restrict the experimental namespace/group cluster agents API to return remote development enabled only
• Maintain the deprecated namespace/group API to return both disabled/enabled agents pending deprecations.

Implementation plan

Org Path

• Remove dependency on NamespaceClusterAgentFilter for the filter parameter
• Introduce OrganizationClusterAgentFilter as an enum to classify ALL and DIRECTLY_MAPPED agents
• Organization WorkspaceClusterAgents query that takes in a compulsory filter parameter of type OrganizationClusterAgentFilter
• Maintain appropriate GraphQL feature specs and associated finder specs

Namespce/Group API backward compatibility Path

• Configure the namespace agent finder to accept a flag of enabled default is false
• Give the deprecated namespace/group API its own resolver that will translate to a finder call that maintains backward compatibility
• Maintain the finder specs to adjust to the additional parameter that will make future cleanup easy