Persist desired kubernetes configuration on workspace creation
MR:
Description
This issue should be taken up after the shadow run of the new desired_config_generator
logic is successful. In other words,
- Both old and new configurations(after injecting secrets) are the same.
- New configuration should not have secret data.
After ensuring that the new logic is running as expected. Persist the configuration returned from Create::DesiredConfig::Generator
. This configuration should be fetched from the database during the reconciliation step.
Acceptance criteria
-
desired_config
should be created while creating the workspace -
desired_config
should be persisted in the database -
During reconciliation step, this desired_config
should be fetched from the database and returned after injecting the secrets with data.
Implementation plan
- Remove the files
ee/lib/remote_development/workspace_operations/reconcile/output/config_to_apply_shadow_run_handler.rb
ee/lib/remote_development/workspace_operations/reconcile/output/desired_config_fetcher.rb
ee/lib/remote_development/workspace_operations/reconcile/output/old_config_values_extractor.rb
ee/lib/remote_development/workspace_operations/reconcile/output/old_desired_config_generator.rb
ee/lib/remote_development/workspace_operations/reconcile/output/old_devfile_parser.rb
ee/lib/remote_development/workspace_operations/reconcile/output/old_scripts_configmap_appender.rb
- Delete all the related spec files.
- Remove
DesiredConfigFetcher
call fromresponse_payload_builder.rb
.
Edited by 🤖 GitLab Bot 🤖