[go: up one dir, main page]

Skip to content

Persist desired kubernetes configuration on workspace creation

MR:

Description

This issue should be taken up after the shadow run of the new desired_config_generator logic is successful. In other words,

  1. Both old and new configurations(after injecting secrets) are the same.
  2. New configuration should not have secret data.

After ensuring that the new logic is running as expected. Persist the configuration returned from Create::DesiredConfig::Generator. This configuration should be fetched from the database during the reconciliation step.

Acceptance criteria

  • desired_config should be created while creating the workspace
  • desired_config should be persisted in the database
  • During reconciliation step, this desired_config should be fetched from the database and returned after injecting the secrets with data.

Implementation plan

  1. Remove the files
    1. ee/lib/remote_development/workspace_operations/reconcile/output/config_to_apply_shadow_run_handler.rb
    2. ee/lib/remote_development/workspace_operations/reconcile/output/desired_config_fetcher.rb
    3. ee/lib/remote_development/workspace_operations/reconcile/output/old_config_values_extractor.rb
    4. ee/lib/remote_development/workspace_operations/reconcile/output/old_desired_config_generator.rb
    5. ee/lib/remote_development/workspace_operations/reconcile/output/old_devfile_parser.rb
    6. ee/lib/remote_development/workspace_operations/reconcile/output/old_scripts_configmap_appender.rb
  2. Delete all the related spec files.
  3. Remove DesiredConfigFetcher call from response_payload_builder.rb.
Edited by 🤖 GitLab Bot 🤖