[go: up one dir, main page]

Move notification action from app/models/member.rb#L689-689 to use event store

Goal

In order to fulfill the notifications design blueprint we need to move every place where we create or resolve todos or notifications to use event store.

Implementation

Please get familiar with the event store documentation.

Please get familiar with the example MR.

Please make sure to follow all conventions from that example and guidelines.

The scope for this work includes:

  • moving the notification action in https://gitlab.com/gitlab-org/gitlab/blob/master/app/models/member.rb#L689-689 to use event store
  • make sure new implementation is feature flagged, as it is required due to canary deployment for GitLab.com. Please use the format: notification_event_store_migration_<event_name>.
  • ensuring the new implementation is tested
  • ensuring the new implementation works like before (of course, moving to event store assumes it's creates asynchronously, which may differ from the previous synchronous implementation)

Remarks

IMPORTANT: If the current code is called asynchronously now, please use your best judgment to migrate it correctly to using the event store.

In case link is no longer relevant (it was captured in April 2025), please remember I meant to cupture updated member access level event and see if the code was moved. In case of further problems, please reach out the Personal Productivity group.

In case you have any questions, please reach out to Personal Productivity group for further assistance.