Fix Workhorse linter warnings (part 19)
Problem
make golangci
linter detects warnings in following Workhorse files
How to verify
make golangci | grep -E "^internal/lsif_transformer/parser/(parser|ranges|referen|result)"
internal/lsif_transformer/parser/parser.go:103:10: Error return value of `pw.Close` is not checked (errcheck)
internal/lsif_transformer/parser/parser.go:15:2: exported: exported var Lsif should have comment or be unexported (revive)
internal/lsif_transformer/parser/parser.go:18:6: exported: exported type Parser should have comment or be unexported (revive)
internal/lsif_transformer/parser/parser.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/lsif_transformer/parser/parser.go:24:1: exported: exported function NewParser should have comment or be unexported (revive)
internal/lsif_transformer/parser/parser.go:36:22: Error return value of `tempFile.Close` is not checked (errcheck)
internal/lsif_transformer/parser/parser.go:38:5: shadow: declaration of "err" shadows declaration at line 25 (govet)
internal/lsif_transformer/parser/parser.go:62:18: Error return value of `file.Close` is not checked (errcheck)
internal/lsif_transformer/parser/parser.go:83:1: exported: exported method Parser.Close should have comment or be unexported (revive)
internal/lsif_transformer/parser/parser.go:84:12: Error return value of `p.pr.Close` is not checked (errcheck)
internal/lsif_transformer/parser/parser.go:93:11: Error return value of `zw.Close` is not checked (errcheck)
internal/lsif_transformer/parser/ranges.go:10:6: exported: exported type Ranges should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:127:1: exported: exported method Ranges.Close should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:140:56: var-naming: method parameter refId should be refID (revive)
internal/lsif_transformer/parser/ranges.go:176:9: var-naming: range var rangeId should be rangeID (revive)
internal/lsif_transformer/parser/ranges.go:17:6: exported: exported type RawRange should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:18:2: var-naming: struct field Id should be ID (revive)
internal/lsif_transformer/parser/ranges.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/lsif_transformer/parser/ranges.go:212:27: var-naming: method parameter rangeId should be rangeID (revive)
internal/lsif_transformer/parser/ranges.go:22:6: exported: exported type Range should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:25:2: var-naming: struct field ResultSetId should be ResultSetID (revive)
internal/lsif_transformer/parser/ranges.go:28:6: exported: exported type RawItem should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:30:2: var-naming: struct field RefId should be RefID (revive)
internal/lsif_transformer/parser/ranges.go:32:2: var-naming: struct field DocId should be DocID (revive)
internal/lsif_transformer/parser/ranges.go:35:6: exported: exported type Item should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:37:2: var-naming: struct field DocId should be DocID (revive)
internal/lsif_transformer/parser/ranges.go:40:6: exported: exported type SerializedRange should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:48:1: exported: exported function NewRanges should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:89:1: exported: exported method Ranges.Serialize should have comment or be unexported (revive)
internal/lsif_transformer/parser/ranges.go:97:9: var-naming: range var rangeId should be rangeID (revive)
internal/lsif_transformer/parser/references.go:12:6: exported: exported type References should have comment or be unexported (revive)
internal/lsif_transformer/parser/references.go:15:2: var-naming: struct field CurrentOffsetId should be CurrentOffsetID (revive)
internal/lsif_transformer/parser/references.go:18:6: exported: exported type SerializedReference should have comment or be unexported (revive)
internal/lsif_transformer/parser/references.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/lsif_transformer/parser/references.go:22:1: exported: exported function NewReferences should have comment or be unexported (revive)
internal/lsif_transformer/parser/references.go:47:28: var-naming: method parameter refId should be refID (revive)
internal/lsif_transformer/parser/references.go:61:20: Error return value of `r.Offsets.SetEntry` is not checked (errcheck)
internal/lsif_transformer/parser/references.go:67:1: exported: exported method References.For should have comment or be unexported (revive)
internal/lsif_transformer/parser/references.go:7:6: exported: exported type ReferencesOffset should have comment or be unexported (revive)
internal/lsif_transformer/parser/references.go:86:1: exported: exported method References.Close should have comment or be unexported (revive)
internal/lsif_transformer/parser/references.go:8:2: var-naming: struct field Id should be ID (revive)
internal/lsif_transformer/parser/references.go:98:31: var-naming: method parameter refId should be refID (revive)
internal/lsif_transformer/parser/references_test.go:11:3: var-naming: const docId should be docID (revive)
internal/lsif_transformer/parser/references_test.go:12:3: var-naming: const refId should be refID (revive)
internal/lsif_transformer/parser/references_test.go:31:8: var-naming: const refId should be refID (revive)
internal/lsif_transformer/parser/result_set.go:10:2: exported: exported const DefinitionProp should have comment (or a comment on this block) or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:14:6: exported: exported type ResultSet should have comment or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:19:6: exported: exported type ResultSetRef should have comment or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/lsif_transformer/parser/result_set.go:20:2: var-naming: struct field Id should be ID (revive)
internal/lsif_transformer/parser/result_set.go:24:6: exported: exported type RawResultSetRef should have comment or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:25:2: var-naming: struct field ResultSetId should be ResultSetID (revive)
internal/lsif_transformer/parser/result_set.go:26:2: var-naming: struct field RefId should be RefID (revive)
internal/lsif_transformer/parser/result_set.go:29:1: exported: exported function NewResultSet should have comment or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:63:1: exported: exported method ResultSet.RefById should have comment or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:72:1: exported: exported method ResultSet.Close should have comment or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:7:6: exported: exported type Property should have comment or be unexported (revive)
internal/lsif_transformer/parser/result_set.go:98:1: exported: exported method ResultSetRef.IsDefinition should have comment or be unexported (revive)
Solution
Resolve warnings
Edited by Vasilii Iakliushin