Pending comments on merge request threads don't show if the comment will resolve the thread
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
When adding multiple comments/replies to an MR we can choose to batch those replies.
If one of those comments/replies would resolve a thread, that is not visible once the comment is saved but pending
See images below for an example:
-
I write a comment, check the
Resolve thread
checkbox and clickAdd to review
(orStart review
) to save the pending comments -
The fact that the comment will resolve the thread is not visible on the pending comment
-
Using the edit button to change the comment shows that the checkbox is indeed still checked (so the status is saved)
Proposal
Use something similar to what we already have to show the result of a slash command to let the user know that the comment will resolve the thread
Similar to this:
But with a message like Solves the thread.