[go: up one dir, main page]

Skip to content

Deprecate stage and entity_id from PipelineWorker - Direct Transfer

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The stage argument stopped from being used in Fix Direct Transfer stages execution order (!132320 - merged), however deprecating and removing the argument from the PipelineWorker worker is challenging as the argument is in the middle of the argument list.

One solution to remove the argument is also to deprecate the entity_id argument, which isn't necessary as we can get the entity_id from the @pipeline_tracker. So deprecating both arguments will allow us to deprecate both arguments stage and entity_id

Proposed solution

To deprecate and remove both arguments, we should follow the Sidekiq development guidelines. And according to the guidelines we should create 3 MRs

  • MR1: Update PipelineWorker not to use the arguments and set a default value to them
  • MR2: Remove the arguments from PipelineWorker.perform_async. This MR should be deployed in a follow-up release
  • MR3: Remove the argument from the argument list. This MR should be deployed in a major release.
Edited by 🤖 GitLab Bot 🤖