[go: up one dir, main page]

Skip to content

Implement group level MR approval rules

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

  • Ensure the frontend has the necessary data on the Group level (Group > Settings).
  • UI changes: render the component created in step 3 (behind feature flag) and ensure backend receives the correct data.
  • Backend/frontend integration on the Group level.

See this comment for additional context.

Frontend work

  1. Conditionally allow for dropdown, when for group level (can be implemented when working on group level)
  2. Conditionally render unconfigured_security_rules.vue, when for project level (can be implemented when working on group level).
  3. Conditionally render table footer, when for group level (can be implemented when working on group level).
  4. Integration with backend

In #425184 we'll add a lock as shown in #425433[project_with_inherited_group_level_mr_approval_rules.png]

Availability and Testing

Additional feature specs:

  • Ensure group level approval rule can be inherited by a project
  • Ensure that if group level approval rules are present, project level approval rules cannot be created
  • Ensure MR's created within a group with group approval rules, get those approval rules (Some of these specs may be created with #425184)

Regression testing, please ensure associated MR is labelled with pipeline:run-all-e2e and e2e:package-and-test job is passing.

Edited by 🤖 GitLab Bot 🤖