[go: up one dir, main page]

Skip to content

Remove lines-between-class-members: off override

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Description

I'd like to remove the lines-between-class-members override, that can be be easily fixed in our code base.

diff --git a/.eslintrc.yml b/.eslintrc.yml
index f98f7acc0ad0..61a4254a8e51 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -33,7 +33,6 @@ rules:
         # consider. See
         # https://gitlab.com/gitlab-org/gitlab/-/merge_requests/89831.
         - '^(ee|jh)_component/'
-  lines-between-class-members: off
   # all offenses of no-jquery/no-animate-toggle are false positives ( $toast.show() )
   no-jquery/no-animate-toggle: off
   no-jquery/no-event-shorthand: off

Discussion

The following discussion from !129953 (merged) should be addressed:

  • @justin_ho started a discussion: (+1 comment)

    Could we also remove the comment above since I believe it's added specifically for this rule?

Edited by 🤖 GitLab Bot 🤖