For settings_panel.vue - add a new gl-form-checkbox-with-hidden-input component
Changes were suggested for app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
- move this
<input type="hidden"...> <gl-form-checkbox ....combination into a reusable<gl-form-checkbox-with-hidden-inputcomponent - add unit test coverage to confirm the child
gl-form-checkbox-with-hidden-inputis rendered
The following discussion from !121585 (merged) should be addressed:
-
@pslaughter started a discussion: thought (non-blocking): I see that we have feature test coverage for this behavior. I was a little surprised that this change didn't cause unit test failures - so I'm guessing there's a pre-existing unit test gap. It's nice if we can push the tests as far down the pyramid as possible.
Nothing we need to take care of here.
Here's an idea - what if we moved this
<input type="hidden"...> <gl-form-checkbox ....combination into a reusable<gl-form-checkbox-with-hidden-inputcomponent with unit test coverage? Then this components unit test can just confirm that this childgl-form-checkbox-with-hidden-inputis rendered.