[go: up one dir, main page]

Skip to content

CODEOWNERS triggered using text detection

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Proposal

Regards,

We suggest that CODEOWNERS would trigger using specific keywords or phrases to limit the number of changes that CODEOWNERS require to review. For example, our current workflow to review, approve and deploy code is based on:

  • General approval: Small changes or hotfixes will have a minimum approval of 1 of 4 people of our organization (Maintainers).
  • Per-module approval: Some modules of our project are assigned to an specific developer, so, any change in this module requires an approval of the owner/lead developer.
  • Sensible approval: Basically, migrations and DB changes requires an approval of a specialist developer or me, currently these changes are triggered by CODEOWNERS using the folders that migrations should be saved.

So, our idea is, instead to trigger CODEOWNERS using the migrations' folders, what if we evaluate the content of the file to detect/match a list of keywords? For example,

[Migrations] @PHKenny
/**/migrations/*.py filter_words:DELETE,UPDATE,TRUNCATE,CREATE OR REPLACE

Where filter_words:... is the prefix/argument of the trigger script of CODEOWNERS, and basically contains a CSV-like list of words or phrases to filter the [Migrations] CODEOWNERS.

Edited by 🤖 GitLab Bot 🤖