[go: up one dir, main page]

Skip to content

Remove no_pagination option support from Blame view

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

It's a follow-up for !119752 (merged)

Description

Blame page for files with many lines can take a while to load.

As the first optimization, we added a pagination for it. But it was not convenient for everybody to use.

The next step was to add a Show full blame button that showed the blame view without pagination. It provided an option no_pagination=true.

Finally, we added a streaming mode that replaces no_pagination step completely.

Blame streaming was fully enabled in Remove Blame page streaming feature flag (!119752 - merged).

Proposal

The code for no_pagination support should be deprecated, because no UI controls define it anymore. It should be safe to remove it.

Related code: https://gitlab.com/gitlab-org/gitlab/blob/81f86be30e01994e01361e400deff5d06a5328de/lib/gitlab/git/blame_mode.rb#L23

Edited by 🤖 GitLab Bot 🤖