[go: up one dir, main page]

Skip to content

Remote Development: Fix all RSpec/ExpectInHook offenses

The following discussion from !105783 (merged) should be addressed:

  • @splattael started a discussion:

    Suggestion (non-blocking) Thoughts using allow instead? 🤔

    Using expectations in hooks is considered bad practice and can lead to confusing spec failures.

          allow(instance).to receive(:calculate_actual_state).with(

    Can we track fixing all RSpec/ExpectInHook offenses in a follow-up issue? 🙏

Have a look in:

  • ee/spec/lib/remote_development/workspaces/reconcile/agent_info_parser_spec.rb
  • ee/spec/lib/remote_development/workspaces/reconcile/reconcile_processor_spec.rb