Test gap: rebase MR with remove approvals settings
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
In gitlab-com/gl-infra/production#8608 (closed) some users were experiencing 500 errors after rebasing their MRs when their projects had the Remove all approvals
setting on.
The user flow that caused the 500 errors (to be confirmed):
- Create project -> Remove all approvals setting on (this may be default) / FF merge on
- Create MR (ensure target has at least one more commit than source)
- Approve MR
- Rebase <- this never completes and this is where the 500 occurs
Check approval removed (may have to wait 10s and refresh as removing approvals is async)Approve MR- Check approval NOT removed as it is a rebase
- Merge
There are two scenarios where this can occur based on the following settings:
- Remove all approvals
- Remove approvals of Code owners
This issue is to ensure we are covering this scenario with either feature specs or an E2E test.
Incident:
Edited by 🤖 GitLab Bot 🤖