[go: up one dir, main page]

Skip to content

Fix Etag generation for Projects::RepositoriesController#archive

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

It's a corrective action for the incident: https://gitlab.com/gitlab-com/gl-infra/production/-/issues/8628

Problem

The change to the archives generation process caused an update of archives hash sums. We reverted the code, but users were still receiving the previous version of archives.

We discovered that Cloudflare was still serving archives from the cache. CF-Cache-Status of these responses was REVALIDATED.

The problem can be caused by ETag that was the same for both correct and incorrect archives. Probably Cloudflare could not identify the change and used the old cache.

Proposal

Update the ETag generation process for archives. If two archives have a different hash sum, then they should have different ETags.

Edited by 🤖 GitLab Bot 🤖