[go: up one dir, main page]

Skip to content

Remove obsolete code from lib/gitlab/email/html_to_markdown_parser.rb

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

As of now, there is this obsolete code in that ruby file:

      # This redefinition can be removed once https://github.com/soundasleep/html2text_ruby/pull/30
      # is merged and released.
      def self.convert(html)
        html = fix_newlines(replace_entities(html))
        doc = Nokogiri::HTML(html)

        new(doc).convert
      end

the pull request that the code comment mentions (https://github.com/soundasleep/html2text_ruby/pull/30) has been merged and the newest release of html2text (0.4.0 https://github.com/soundasleep/html2text_ruby/releases/tag/v0.4.0) has that pull request merged, so therefore this obsolete code should be removed.

Edited by 🤖 GitLab Bot 🤖