[go: up one dir, main page]

Skip to content

Add filter for merge requests that I have approved and approval was removed/reset

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Description

Add a filter for merge requests that have had approvals removed or reset.

Use Case

  1. First reviewer goes back and forth with submitter, and eventually approves merge.

  2. Second reviewer goes back and forth with submitter, resulting in changes that remove the first reviewer’s approval. Second reviewer approves merge.

    · The amount of time between the changes that revoke the approval of the first reviewer and the second reviewer being done could be several days, or a week. A one-time notification will be lost and forgotten by then.

  3. First reviewer doesn’t realize/remember that they need to review the merge again, and so the merge sits until somebody notices.

We would like to see an additional badge in the merge request view that shows on a per-user basis for “merge requests that I approved in the past, where my approval was removed.” Since the reviewers are looking at the merge request view every day, a visual cue there will be more effective than a one-time notification. A filter option would also probably be useful.

Links / references

Customer Ticket -> https://gitlab.zendesk.com/agent/tickets/90684 (internal)

Edited by 🤖 GitLab Bot 🤖