MR edit page: Click on approver avatar should assign them as reviewer
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Release notes
When Code Owners are configured and approval rules are defined, the Merge Request form contains a table with projects members who can approve. Clicking on a user avatar in this table now assigns them as a reviewer. Before, a click would open their profile page, potentially losing the MR form data.
Problem to solve
In the /merge_requests/:id/edit form, user/member avatars are shown under Code owner approval is required if any such rules are configured. The avatars are linked to the /:username profile page, so that clicking them accidentally can abort the MR form and potentially lose edits. Browsers can help retain/restore those, but still.
Proposal
Assuming that the most likely scenario in that /merge_requests/:id/edit form is wanting to complete the form:
- we could implement a click action on the avatars that assign them as reviewers,
- instead of linking the avatars to another page.
It seems unlikely that anyone editing an MR would in that moment want to not assign the approvers, but see their profile page.
Intended users
Anyone who creates MRs.