[go: up one dir, main page]

Skip to content

Add WorkspacesAgentConfigSettings step to the Workspaces Settings Module

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

MR: Pending

NOTE: We need to decide on the proper field, max_hours_before_termination_limit may not be the best choice anymore

Description

Add WorkspacesAgentConfigSettings step to the Workspaces Settings Module. The related UI for editing agent config settings will be added by UX: Move GitLab Agent config to UI element (#457760)

Acceptance Criteria

  • Decide the appropriate field. See gitlab-org#14186 (comment 2066748871) for relevant discussion.
  • Add step for WorkspacesAgentConfigReader, after CurrentSettingsReader
  • Fully exercise new behavior in spec/lib/remote_development/settings/settings_integration_spec.rb
  • Add any places which directly read from table to instead read from settings module.
  • Adds documentation

Technical Requirements

  • This will extend support for max_hours_before_termination_limit to the agent config level.
  • This will involve adding a new AgentSettings step to the Workspaces ROP Settings Module chain
  • This doesn't involve creating any GraphQL API for that field, that will be done as part of the following UX issue

Design Requirements

None, no UI-facing changes.

Edited by 🤖 GitLab Bot 🤖