Frontend : about "toolbar" on the merge request's commit page
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
Let's look at the "toolbar" on the merge request's commit page:
We have (from the left to the right):
No | item | object |
---|---|---|
1. |
Hide file browser toggle |
view regulation |
2. | Viewing commit <commit SHA> |
current commit |
3. |
< Prev button |
current commit |
4. |
Next > button |
current commit |
5. |
Show latest version button |
whole merge request |
6. | Gap | - |
7. | Stat hint | current commit |
8. |
Preferences button |
view regulation |
So:
- There are many different items in one visual line.
- The
current commit
/whole merge request
/view regulation
items are mixed.- Which includes the
Show latest version
button being misrepresented as the commit-switcher-like button (but it shows the whole merge request diff instead). See also 3e66795e (comment 2025786503).
- Which includes the
Why this matters and how we measure
It confuses the user.
Proposal
Separate the current commit
/whole merge request
/view regulation
items.
Like:
- Rearrange items.
- Insert more gaps.
- Introduce the second "toolbar",
- etc.
Thanks!
Edited by 🤖 GitLab Bot 🤖