follow up issue for remote development bug and code quality
MR: Pending
Description
Also there is a small bug with our current code based on the note here:
@zhaochen_li We still needed to create an issue to fix the bug:
But if we did this, it would actually uncover a bug we have in the
ee/app/graphql/mutations/remote_development/namespace_cluster_agent_mappings/create.rb
class, where we are incorrectly returning the key ofworkspace
instead ofnamespace_cluster_agent_mapping
. This is untested and made it past review, and apparently nobody has noticed.
Look into the issue with facotry reload
Based on the comment here, we would like to move remote_Development fields into our own module, and add it into the ancestor chain to the ee/app/graphql/ee/types/clusters/agent_type.rb
Based on the comment here, we would like to update the testing to do more real reflection.
Acceptance Criteria
-
fix the bug with returning key -
do code refactor above -
add sufficient unit testing