[go: up one dir, main page]

Skip to content

Feature "Remove approvals by Code Owners if their files changed" does not remove approval

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

The merge request got approved by a code owner. Then the author of the merge request made changes and amended the commit, did a rebase and pushed. After that the approval for changed files covered by CODEOWNERS wasn't removed as it should have been.

Steps to reproduce

  1. Merge request approved by Code Owner
  2. Merge request owner amended the commit
  3. Merge request owner did a rebase on the target branch with 100+ commits
  4. Merge request owner did a push
  5. Approvals for changed files covered by CODEOWNERS not removed

What is the current bug behavior?

The approvals for changed files covered by CODEOWNERS does not get removed.

What is the expected correct behavior?

The approvals for changed files covered by CODEOWNERS should get removed.

Edited by 🤖 GitLab Bot 🤖