[go: up one dir, main page]

Skip to content

Follow-up from "Workhorse: HTTP endpoint for bidirectional SSH git-upload-pack data"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The following discussion from !152950 (merged) should be addressed:

  • @ashmckenzie started a discussion:

    suggestion (nitpick): We could early return and save some indentation etc:

            return super unless geo?
    
            set_workhorse_internal_api_content_type
    
            render json: ::Gitlab::Workhorse.git_http_ok(repository, repo_type, user, :git_upload_pack, show_all_refs: geo_request?, need_audit: need_git_audit_event?)

    This could be a follow-up as it's very nitty 🙂

Edited by 🤖 GitLab Bot 🤖