Follow-up from "Edit Branch Rules: UI for Branch protection toggles"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

The following discussion from !153281 (merged) should be addressed:

• @psjakubowska started a discussion: (+1 comment)

  @jerasmus I've realised we've guarded delete and edit actions behind a feature flag, but haven't introduced canEdit yet. I injected it for toggle, but I am right that I should follow-up with the MR that uses it for other editing option, right?

  I mean:

  • deleting a rule
  • editing a custom rule pattern
  • is-edit-available on protection component

  @psjakubowska if I remember correctly, can_edit is used for checking if a user can edit approval rules. It comes from this helper, so I don't think we should use it for the other edit actions. But now that you've bought it up, I can definitely see how the name of this property can be confusing 😄 Perhaps we should rename it to something more descriptive like can_edit_approval_rules 🤔 We can do this in a follow-up though.