[go: up one dir, main page]

Skip to content

Do not persist extensions gallery workspace variables if marketplace is disabled

MR: Pending

Description

The following discussion from Enable VS Code private extensions marketplace f... (!147718 - merged) should be addressed:

Regarding question above:

question; follow-up; non-blocking

When GL_EDITOR_ENABLE_MARKETPLACE is false, GL_EDITOR_EXTENSIONS_GALLERY_SERVICE_URL, GL_EDITOR_EXTENSIONS_GALLERY_ITEM_URL, GL_EDITOR_EXTENSIONS_GALLERY_RESOURCE_URL_TEMPLATE are technically not required. They are just extra entries in the DB. Should we then add them to the workspaces_variables? Shouldn't we make it conditional?

Yes, this is a good point. Lets make this a follow-up issue.

Acceptance Criteria

TODO: Fill out (required)

  • [Describe what must be achieved to complete this issue.]
  • [Describe another requirement needed to complete this issue.]
  • [Add additional acceptance criteria as needed.]

Technical Requirements

TODO: Fill out or delete (optional) [If applicable, please list out any technical requirements for this feature/enhancement.]

Design Requirements

TODO: Fill out or delete (optional) [If applicable, please provide a link to the design specifications for this feature/enhancement.]

Impact Assessment

TODO: Fill out or delete (optional) [Please describe the impact this feature/enhancement will have on the user experience and/or the product as a whole.]

User Story

TODO: Fill out or delete (optional) [Provide a user story to illustrate the use case for this feature/enhancement. Include examples to help communicate the intended functionality.]

Edited by Chad Woolley