[go: up one dir, main page]

Skip to content

Follow-up from "Blob refactor: Add ability to lock/unlock a blob"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The following discussion from !67408 (merged) should be addressed:

  • @rob.hunt started a discussion: (+1 comment)

    suggestion (non-blocking): WDYT about using GlModal like the replace and delete buttons? If you agree, happy for this to be a follow-up

Context

Before we refactored the Lock button we were using window.confirm to confirm whether or not a user wants to lock/unlock a file. When we refactored the code we kept window.confirm and decided to implement a GlModal dialog in a follow-up.

This is a proposal to rather use GlModal instead of window.confirm.

Edited by 🤖 GitLab Bot 🤖