Follow-up from "GithubImporter: Count and log each object imported"
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The following discussion from !64256 (merged) should be addressed:
-
@mkaeppler started a discussion: I'm not super well versed in Redis specifics, but I'm always suspicious of doing synchronous I/O in loops. This is performing a Redis roundtrip
n
times sequentially but does not depend on the loop variable. I would check how many times we might be doing this here (max) as a function of collection length (also: how often we enter this loop!)Redis supports pipelining which allows for more efficient use of the client connection when many operations needs to be performed and can run in parallel i.e. without waiting for a response. Looks like we don't have an API for
ObjectCounter
yet that can perform a pipelinedincr
. Maybe we can add this in a follow-up?