[go: up one dir, main page]

Skip to content

Feature Request: Wait to ping reviewers until pipeline succeeds

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Release notes

When creating a Merge Request, authors can now enable a new feature to have Gitlab wait to ping reviewers until the MR pipeline succeeds. This is in particular helpful in configurations where changes dismiss reviews, as a failing pipeline likely requires changes. In that case, an approval wouldn't have any value if the pipeline has or will fail.

Problem to solve

Similar to the feature to merge when ready, this reduces the number of times a MR author needs to come back for follow-up actions. If the pipeline passed, reviewers get pinged and when combined with merge-when-ready the MR gets merged without the author ever needing to come back. If the pipeline fails, no reviewer gets pinged and the author can fix the MR without needing to request a reviewer to re-approve.

Proposal

There would be a checkbox or button when creating a MR, similar to merge-when-ready:

Intended users

User experience goal

The user should be able to check a box when creating a MR to to have GitLab wait to ping reviewers until the pipeline has succeeded.

Permissions and Security

Edited by 🤖 GitLab Bot 🤖