[go: up one dir, main page]

Skip to content

merge request webhook - add first commit details

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Release notes

Problem to solve

A GitLab Premium customer raised a ticket about producing merge request statistics. They were interested in tracking the time from first commit to merge (for GitLab team members: ticket)

While our analytics solution might address their need (it has some limitations, such as rounding down to whole days) there may be other use cases as well.

For example, merge requests help address a key questions that often arises: what's changed on this branch. Until a MR exists, it's not possible to know what the effect of a feature branch is - the target branch provides the baseline to measure the change against.

The last commit provides no more information than the branch's HEAD commit provides. The first commit allows a range of commits to be identified, and this the effect of the MR can potentially be identified.

Intended users

Customer's use case (measuring time from first commit)

Other potential use cases, around measuring the effect of a MR.

User experience goal

MR events include the first commit

Currently last commit is included:

      "url":"http://example.com/awesome_space/awesome_project.git",
      "ssh_url":"git@example.com:awesome_space/awesome_project.git",
      "http_url":"http://example.com/awesome_space/awesome_project.git"
    },
    "last_commit": {
      "id": "da1560886d4f094c3e6c9ef40349f7d38b5d27d7",
      "message": "fixed readme",
      "timestamp": "2012-01-03T23:36:29+02:00",
      "url": "http://example.com/awesome_space/awesome_project/commits/da1560886d4f094c3e6c9ef40349f7d38b5d27d7",
      "author": {
        "name": "GitLab dev user",
        "email": "gitlabdev@dv6700.(none)"
      }
    },
    "work_in_progress": false,
    "url": "http://example.com/diaspora/merge_requests/1",
    "action": "open",

Include first commit as well:

    "first_commit": {
      "id": "de9c7cfc256754b0f669bc468a5aa769a036e085",
      "message": "created readme",
      "timestamp": "2012-01-01T20:36:29+02:00",
      "url": "http://example.com/awesome_space/awesome_project/commits/de9c7cfc256754b0f669bc468a5aa769a036e085",
      "author": {
        "name": "GitLab dev user",
        "email": "gitlabdev@dv6700.(none)"
      }

Proposal

Further details

Permissions and Security

Documentation

Availability & Testing

Available Tier

What does success look like, and how can we measure that?

What is the type of buyer?

Is this a cross-stage feature?

Links / references

I don't see webhooks or MR events in the features list so I'm assigning this to groupcode review

Edited by 🤖 GitLab Bot 🤖