[go: up one dir, main page]

Skip to content

gitlab-zip-metadata depends on RemoteURL even when S3 client is enabled

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

While looking at #223806 (closed), I noticed that Workhorse uses the RemoteURL to extract the artifacts metadata (https://gitlab.com/gitlab-org/gitlab-workhorse/blob/b7b5ef822170cbd72fe99a316e45eb34b133db57/internal/zipartifacts/open_archive.go#L71).

If the S3 client is enabled, we might want to make gitlab-zip-metadata use the S3 client directly. Or we could generate the pre-signed URL inside Workhorse so Rails doesn't need to do this. Not sure about this one.

Edited by 🤖 GitLab Bot 🤖