Finish Review button UX is very confusing
There are various UX issues with the code review page (I have encountered all these as a new Gitlab user):
- It's not very clear what the difference between "Start a Review" and "Add comment now" is. See this SO question for example.
- If you do "Start a Review" it leaves the comment as "Pending". Not clear what that means.
- Most critically, the "Finish review" button is really hidden right at the bottom of the screen in the place where nobody looks because there's never anything useful there.
You may dismiss these as obvious... and they are obvious once you know, but both I and a colleague started a review without realising the comments hadn't been sent within the space of a week. If it's that common I don't think it's us. Plus I never had this problem with the equivalent functionality in Phabricator.
I'm sure you have UX guys but my suggestions would be:
- Rename "Start a review" / "Add comment now" to "Save draft comment" / "Send comment now"
- Move the "Finish review" button to the top. That's where people look.
- Change "Pending" to "Draft" or maybe "Draft (click Finish Review to send)".