[go: up one dir, main page]

Skip to content

Indicate which merge requests could use the logged-in user's approval (based on required approvers on the MR)

Problem to solve

When there's a lot of open merge requests, it's hard to tell which merge requests could use my attention and which do not, especially when approval groups are used. If a merge request requires approval from 4 groups, "3 approvers" could mean it still could use my approval, but it could also mean it's already approved by a member of my approval group. There is currently no clear way to tell the difference without clicking on every merge request individually.

Intended users

All users that approve merge requests.

Further details

The merge requests screen is one of the most commonly-used screens. It's important to optimize the workflow for users, so they can use the screen efficiently.

Proposal

Display some indication next to the merge request approval count on the merge_requests screen that indicates to the user which merge requests could use their approval and which do not.

  • If the user is part of one or more approver groups on the MR and there hasn't been a sufficient amount of approvers from all of those approver groups, display an indication to the user to draw their attention to that merge request.

  • If the user is not part of any approver group on the MR, do not display any indication

  • If the user is part of one or more approver groups on the MR and there is a sufficient amount of approvers from all of those approver groups, do not display any indication.

Permissions and Security

No permissions/security concerns.

Documentation

Unknown

Testing

Unknown

What does success look like, and how can we measure that?

Success metrics:

  • Less time will need to be spent by merge request approvers looking over the list of open merge requests.

Acceptance criteria:

  • For a given logged in user, it is easily apparent on the merge request screen which merge requests could use their approval and which do not.

What is the type of buyer?

Unknown

Links / references

Edited by Oscar McCully