Decide what to do with skipped flash notice assertions in spec/features/projects/settings/repository_settings_spec.rb
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
In !105032 (merged), !105236 (merged), and !105523 (merged), we skipped some flash notice assertions as the flash notice was replaced by another one (due to an unrelated bug).
As said in !105236 (comment 1191357648):
I think the skipped assertions could be removed entirely as the test already checks its result another way (i.e.
expect(RepositoryCleanupWorker.jobs.count).to eq(1)), or change the assertion to not check for a flash notice. In general, I think it's always a bad idea to assert on flash notices as you cannot be sure a flash notice won't be replaced dynamically with another one at runtime. It's better to assert on a fixed text in the page (if available) instead.
This issue is to investigate if we should replace the flash notice assertions with more robust assertions, or remove them entirely.