[go: up one dir, main page]

Skip to content

Add UI tests for commit signature badges

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Why are we doing this work

The commit signature badges are rendered via several HAML templates in https://gitlab.com/gitlab-org/gitlab/-/tree/3f56fd6515ae57f91c5b7619381a14f84c3843c0/app/views/projects/commit.

Currently, we do not have any tests for these. We should add tests for all signatures types and also all signature verification states. The test bootstrapping for signatures is also non-trivial, so this may be a good opportunity to add some shared-contexts for these.

Relevant links

Non-functional requirements

  • Documentation:
  • Feature flag:
  • Performance:
  • Testing:

Implementation plan

Add tests for the signature badge to spec/views/projects/commit/show.html.haml_spec.rb.

Verification steps

Edited by 🤖 GitLab Bot 🤖