Follow-up from "Approvers group does not persist after adding it to the approval rules"
The following discussion from !100192 (merged) should be addressed:
-
@reprazent started a discussion: How many
group_ids
do we allow being passed in here, is there a limit?Since this query could get quite big when passed into the query, we might want to limit it. However, this is not a new thing here, we did the same with the previous query.
What do you think about adding an explicit upper bound of 100 groups? Since we can never require more than 100 approvals anyway: https://gitlab.com/gitlab-org/gitlab/blob/1eacf8a2dd618d798febd3e0d6bdd6c725f64c8d/ee/app/models/concerns/approval_rule_like.rb#L9
This can be in follow up.