Review Gitlab::GithubImport::ParallelScheduling and make interface methods as private if possible
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
Few methods of Gitlab::GithubImport::ParallelScheduling looks like could be placed under private access level. For example: representation_class, importer_class, sidekiq_worker_class, collection_method etc. With placing this methods under private scopes we will probably remove batch of specs around all classes that uses it.
Improvements
- make code clearer from the side "in internal only or external places this method is used"
- removes useless specs around interfaces that (probably by usage) aren't public and don't have much of logic to be covered in individual way and prevents to write such specs in future.
Risks
Need to double check all GitHub importing areas as this module is used in most of them. Although smoke tests should be pretty enough because this module is about high level objects iterating and running specific importer and not about any area-specific uniq logic aspects.
Involved components
lib/gitlab/github_import/importer//*.rb spec/lib/gitlab/github_import/importer//*_spec.rb