Improve slow tests in ./spec/support/shared_examples/integrations/integration_settings_form.rb:7

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Summary

The total running time of ./spec/support/shared_examples/integrations/integration_settings_form.rb:7 is 181.04 seconds and it executes 3226 queries. It is likely this can be improved. Please review this suite or example for opportunities to fix slow tests.

Description

This issue was generated from the rspec profiling project which profiles rspec tests in pipelines run against the default branch on gitlab-org/gitlab.

gg "it_behaves_like 'integration settings form"
ee/spec/features/projects/integrations/project_integrations_spec.rb:  it_behaves_like 'integration settings form' do
spec/features/admin/integrations/instance_integrations_spec.rb:  it_behaves_like 'integration settings form' do
spec/features/groups/integrations/group_integrations_spec.rb:  it_behaves_like 'integration settings form' do
spec/features/projects/integrations/project_integrations_spec.rb:  it_behaves_like 'integration settings form' do

Proposal

1. Do we need to test 40-odd integration types on the feature spec level ?
2. ./spec/support/shared_examples/integrations/integration_settings_form.rb:7 can probably be broken up into one spec per integration type.

/cc @sgregory2