[go: up one dir, main page]

Skip to content

Clicking link to Pending comments on previous diffs do nothing from Overview/Commits/Pipelines tab

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

When pending comments are made on a previous commit in an MR, the links from the review bar to the pending comments do not work when you aren't on the Changes tab.

Very similar to Selecting pending comments does not work for co... (#350366 - closed) which is fixed, but this occurs from Overview/Pipelines/Commits tab

Steps to reproduce

  1. Create an MR with at least two commits
  2. Navigate to a commit that is not the latest commit
  3. This will open the Changes tab
  4. Start a review and add a Pending Comment
  5. From the Overview, Commits, or Pipeline tab select the pending comment

pending_comments_overview

Example Project

What is the current bug behavior?

Page refreshes, pending comment not displayed

What is the expected correct behavior?

Changes tab displayed, pending comment displayed

Results of GitLab environment info

5c603ef6

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Edited by 🤖 GitLab Bot 🤖