Make it easier to review individual commits in merge requests
In recent releases of GitLab we've seen a few changes on the merge request page that, in my opinion, have made reviewing merge requests more difficult.
The main issue is this: there seems to be no way to select a commit and see both diff and message on the same page. This results in a lot of uncomfortable moving back and forth between the commit list (where commit messages are visible) and the diff view.
This is probably subjective and to large extent dependent on the workflow of the person doing the code review, but I would argue that in order to fully understand the reasoning behind certain changes it is essential to carefully read both the commit message and the diff. By separating these two we make it harder for a reviewer to parse commits, especially for commits where the motivation for the change is not obvious.
As of 11.1.0 (possibly a bit earlier) the merge request page seems to have no links to specific commit pages (where both message and diff are visible).
A few suggestions for the merge request page:
-
Add links to specific commit pages in the commit list and the diff view
-
Show the complete commit message in the diff view when inspecting a specific commit
-
Change the page title to the title line of the commit message when inspecting the diff of a specific commit (this would help when opening commits from the commit list in new browser tabs)