[go: up one dir, main page]

Skip to content

Use common layout for merge request email templates

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The following discussion from !33460 (merged) should be addressed:

  • @tkuah started a discussion:

    I diffed with the approved template with tkdiff ee/app/views/notify/approved_merge_request_email.html.haml app/views/notify/merge_when_pipeline_succeeds_email.html.haml. Looks similar to that template except for externationalization and removal as slashes, as expected.

    It will be nice to use layouts to DRY this up but this can be done as a follow-up.

Several mail templates could be DRYed to use common layout

The following elements can be DRYed:

  1. %html.head
  2. %body
Edited by 🤖 GitLab Bot 🤖